Skip to content

[lldb][cxx-interop] Tell LLDB about the extra layer of indireciton for foriegn reference types. #59679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

zoecarver
Copy link
Contributor

No description provided.

@zoecarver zoecarver added the c++ interop Feature: Interoperability with C++ label Jun 23, 2022
@zoecarver zoecarver requested a review from adrian-prantl June 23, 2022 21:38
@zoecarver
Copy link
Contributor Author

@swift-ci please test.

@zoecarver
Copy link
Contributor Author

@adrian-prantl not really sure how to write a test for this. Could you point me to an example swift/lldb test?

@zoecarver zoecarver marked this pull request as ready for review June 23, 2022 21:39
@adrian-prantl
Copy link
Contributor

For Swift, you could copy https://github.com/apple/swift/blob/main/test/DebugInfo/generic_arg.swift, which also checks for a DW_OP_deref on a local variable.

@adrian-prantl
Copy link
Contributor

For the imported types, it's best to create a C++ module in Inputs/, like https://github.com/apple/swift/blob/main/test/DebugInfo/C-typedef.swift does.

@adrian-prantl
Copy link
Contributor

For LLDB it could be based off of https://github.com/apple/llvm-project/tree/next/lldb/test/API/lang/swift/any . We should probably create a new subdirectory for the C++ tests there. I can write the first test and add you as a reviewer and then you can copy that going forward.

@zoecarver zoecarver merged commit 4044b27 into swiftlang:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants