[5.7][SE-0358][stdlib] Adopt primary associated types #59694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7a7ebd8)
(cherry picked from commit 6d09bb0)
(cherry picked from commit 191eaad)
Co-authored-by: Ben Rimmington <[email protected]> (cherry picked from commit 9f177d1)
(cherry picked from commit 655f085)
…zyCollectionProtocol for now (cherry picked from commit 063c845)
…tor protocols (cherry picked from commit eed5bd1)
`Element` is expected to always be `Self`. `RawValue` would be a better choice for the primary type ("option set of UInt32"), but to avoid confusion, it seems better to just omit the declaration, at least for now.
(cherry picked from commit 2759a71)
|
@swift-ci test |
stephentyrone
approved these changes
Jun 28, 2022
lorentey
added
the
swift evolution approved
lorentey
added a commit
to swiftlang/swift-evolution
that referenced
this pull request
Jun 29, 2022
swiftlang/swift#59694 has landed on the release/5.7 branch.
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #41843, this implements SE-0358.
Explanation: This implements SE-0358 as of the proposal's third review. While the proposal is still in review, I'm reasonably confident this set of definitions will remain in the final version, and landing this now unblocks some regular expressions work.
Scope: Standard Library protocol definitions.
Risk: Low. The primary risk is that older compilers won't be able to parse the new protocol declaration syntax; however, the associated compiler improvements have landed long ago in the 5.7 release cycle.
Testing: Existing automated regression tests.
Reviewer: @slavapestov
Issue: rdar://89108942