[AST] Teach computeNominalType about nested ObjC protocols
#59756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objective-C protocols unlike their Swift counterparts could be nested in other types, so `computeNominalType` has to fetch a parent for such protocols (if any) just like importer does. Resolves: rdar://95084142
hborla
approved these changes
Jun 28, 2022
|
@swift-ci please test |
slavapestov
reviewed
Jun 28, 2022
|
@swift-ci please test |
|
I'm reverting back to using the check since removing it re-introduced regressions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective-C protocols unlike their Swift counterparts could be
nested in other types, so
computeNominalTypehas to fetch aparent for such protocols (if any) just like importer does.
Resolves: rdar://95084142