Platform: add a definition for std on Windows
#59767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the c++ module for Windows to help further the C++ interop.
|
@swift-ci please test |
|
CC: @egorzhdan @zoecarver @hyp |
Remove `spanstream` header from the module until we can identify a way to do per-release variants.
|
@swift-ci please test |
|
@swift-ci please build toolchain windows platform |
egorzhdan
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Looks amazing! Does clang report any modularization issues when trying to import that module? If not, that's great!
Could you please also add a test for the stdlib module interface? We already have these tests for libc++ and libstdc++ (swift/test/Interop/Cxx/stdlib).
(doesn't have to be a part of this PR)
|
clang doesn't seem to object any longer. There was a fair amount of restructuring that I did to get this to work. The tests and a couple of small samples locally seem to be able to use |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jul 2, 2022
Add a test to verify that the C++ module is importable and expected functions are visible. This was requested in swiftlang#59767 by @egorzhdan.
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Aug 11, 2022
Add a test to verify that the C++ module is importable and expected functions are visible. This was requested in swiftlang#59767 by @egorzhdan.
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Aug 12, 2022
Add a test to verify that the C++ module is importable and expected functions are visible. This was requested in swiftlang#59767 by @egorzhdan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the c++ module for Windows to help further the C++ interop.