Skip to content

[5.7][IRGen] Use existential AnyObject throughout IRGen. #59769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2022
Merged

[5.7][IRGen] Use existential AnyObject throughout IRGen. #59769

merged 1 commit into from
Jun 29, 2022

Conversation

hborla
Copy link
Member

@hborla hborla commented Jun 29, 2022

Cherry-pick of #59760

  • Explanation: Previously, some places in IRGen used getAnyObjectConstraint and others used getAnyObjectType. This inconsistency could cause crashes in IRGen when emitting metadata for types with AnyObject properties.
  • Scope: Affects the representation of AnyObject in IRGen.
  • Risk: Low.
  • Testing: Manually built modules where the crash manifested (with no luck in isolating a test case).
  • Reviewer: @slavapestov

Resolves: rdar://95945015

@hborla hborla requested a review from a team as a code owner June 29, 2022 01:43
@hborla
Copy link
Member Author

hborla commented Jun 29, 2022

@swift-ci please test

@hborla hborla added the r5.7 label Jun 29, 2022
@hborla hborla merged commit 5f19fdf into swiftlang:release/5.7 Jun 29, 2022
@hborla hborla deleted the 5.7-irgen-anyobject branch June 29, 2022 15:45
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hborla @tbkka @AnthonyLatsis