-
Notifications
You must be signed in to change notification settings - Fork 10.5k
🍒[5.7][Distributed] Implement distributed computed properties via special accessor #59774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ktoso
wants to merge
16
commits into
swiftlang:release/5.7
from
ktoso:pick-distributed-computed-properties-via-thunk
Closed
🍒[5.7][Distributed] Implement distributed computed properties via special accessor #59774
ktoso
wants to merge
16
commits into
swiftlang:release/5.7
from
ktoso:pick-distributed-computed-properties-via-thunk
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DistributedThunk` is to be used while accessing 'distributed' computed property outside of its actor context.
This strategy is used to dispatch accesses to 'distributed' computed property to distributed thunk accessor instead of a regular getter when access happen outside actor isolation context.
The attribute comes handy during solution application to determine whether the call is using a distributed thunk.
… computed properties
…uted thunks Distributed thunks have to refer to the "local" version of the property directly with implicit `self.` base.
@swift-ci please test |
@swift-ci please build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
distributed
Feature → concurrency: distributed actor
🍒 release cherry pick
Flag: Release branch cherry picks
swift 5.7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This implements a missing feature, distributed computed properties. This is a reimplementation after one implementation approach was asked to be reverted. This is the approach discussed with @DougGregor recently.
Testing: PR Testing
Depends on: #59736 because otherwise we're in conflict hell between those building on one another
Original PR: #59700
Resolves: rdar://91283164