🍒[5.7][Distributed] Implement distributed computed properties via special accessor #59809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Doug Gregor <[email protected]>
`DistributedThunk` is to be used while accessing 'distributed' computed property outside of its actor context.
This strategy is used to dispatch accesses to 'distributed' computed property to distributed thunk accessor instead of a regular getter when access happen outside actor isolation context.
The flag is used to distinguish between regular functions/accessors and synthesized distributed thunks.
… computed properties
…uted thunks Distributed thunks have to refer to the "local" version of the property directly with implicit `self.` base.
…Decl` One step towards future distributed subscripts.
Only distributed functions and computed properties should be accepted, everything else is invalid.
It used to be an accessor but that is not required because SILDeclRef controls mangling which is the most imprortant and could be used to emit the right reference.
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please test |
ktoso
force-pushed
the
pick-dist-properties-xedin
branch
from
eea5af6 to
50e04f2
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Jun 30, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Implements computed distributed get-only properties using a special accessor implementation approach. This implements a missing piece of the distributed feature, by @xedin
Risk: Low, unlocks missing functionality and does not affect existing code.
Review by: @DougGregor
Testing: PR testing on CI
Original PR: #59700
Radar: rdar://91283164
Depends on #59736 for a clean cherry pick;
Let's first merge #59736 which also has addressed the comments by now, and then this and it'll apply cleanly 👍