Skip to content

[AST] Pack bitfields in TypeRepr #5981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Nov 30, 2016

Follow up on #5926

Pack bitfields in TupleTypeRepr into the bitfield union.

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice compacting here. Thanks, Rintaro!

@rintaro
Copy link
Member Author

rintaro commented Nov 30, 2016

@swift-ci Please smoke test

: underscoreLocs.empty() ? HasNames : HasLabels;
TupleTypeReprBits.NameStatus = ElementNames.empty() ? NotNamed
: underscoreLocs.empty() ? HasNames : HasLabels;
TupleTypeReprBits.HasEllipsis = Ellipsis.isValid();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent, will fix.

@rintaro
Copy link
Member Author

rintaro commented Nov 30, 2016

@swift-ci Please smoke test

@rintaro rintaro merged commit e60daaa into swiftlang:master Dec 1, 2016
@rintaro rintaro deleted the ast-typerepr-bits branch December 1, 2016 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants