Skip to content

Revert "Fix nested generic typerefs applying generic params at the wrong level" #59838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Jul 1, 2022

Provisionally revert #59262 to see whether that might fix these build errors

/Users/ec2-user/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_long-test/swift/stdlib/public/runtime/MetadataLookup.cpp:1336:5: error: unknown type name 'BuiltType'
    BuiltType Ptr;
    ^
/Users/ec2-user/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_long-test/swift/stdlib/public/runtime/MetadataLookup.cpp:1340:25: error: unknown type name 'BuiltType'
    BigBuiltTypeIntPair(BuiltType ptr, RequirementKind i) : Ptr(ptr), Int(i) {}
                        ^
/Users/ec2-user/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_long-test/swift/stdlib/public/runtime/MetadataLookup.cpp:1342:5: error: unknown type name 'BuiltType'
    BuiltType getPointer() const { return Ptr; }
    ^
/Users/ec2-user/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_long-test/swift/stdlib/public/runtime/MetadataLookup.cpp:1375:11: error: member initializer 'RequirementBase' does not name a non-static data member or base class
        : RequirementBase(kind, first, second) {}
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ec2-user/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_long-test/swift/stdlib/public/runtime/MetadataLookup.cpp:1378:11: error: member initializer 'RequirementBase' does not name a non-static data member or base class
        : RequirementBase(kind, first, second) {}
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ec2-user/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_long-test/swift/stdlib/public/runtime/MetadataLookup.cpp:1336:15: warning: private field 'Ptr' is not used [-Wunused-private-field]
    BuiltType Ptr;
              ^
1 warning and 5 errors generated.

seen on the following bots:

https://ci.swift.org/job/oss-swift-incremental-RA-macos/980/
https://ci.swift.org/job/oss-swift-package-macos/652/
https://ci.swift.org/job/oss-swift-pr-test-macoss/750/
https://ci.swift.org/job/oss-swift_tools-R_stdlib-RD_test-simulator/885/
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-device-non_executable/1084/
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-simulators/535/
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/778/
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_long-test/721/
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-simulator/595/
https://ci.swift.org/job/swift-main-sourcekitd-stress-tester/130/

@nate-chandler
Copy link
Contributor Author

buildbot,tools=RA,stdlib=RDA,long_test
@swift-ci Please test with preset macOS

@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

@nate-chandler
Copy link
Contributor Author

This change can't be responsible. Closing.

@nate-chandler nate-chandler deleted the revert-59262-nested-generic-typeref branch July 1, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant