Skip to content

[5.7] Implement symbolic demangling for extended existential metadata #59845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rjmccall
Copy link
Contributor

@rjmccall rjmccall commented Jul 1, 2022

Fixes rdar://96268090. 5.7 version of #59808.

@rjmccall rjmccall requested a review from a team as a code owner July 1, 2022 17:59
@rjmccall
Copy link
Contributor Author

rjmccall commented Jul 1, 2022

@swift-ci Please test

Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the symbolic references bits, but the mangling and MetadataReader bits LGTM

@rjmccall rjmccall force-pushed the rjmccall/extended-existential-symbolic-mangling-5.7 branch from 7f1b02f to 75f2ea5 Compare July 2, 2022 00:00
@rjmccall
Copy link
Contributor Author

rjmccall commented Jul 2, 2022

Passed tests, but there were conflicts for some reason, presumably between the version of Robert's PR that I cherry-picked and what was actually merged; re-testing.

@rjmccall
Copy link
Contributor Author

rjmccall commented Jul 2, 2022

@swift-ci Please test

@rjmccall rjmccall merged commit 970457b into swiftlang:release/5.7 Jul 2, 2022
@rjmccall rjmccall deleted the rjmccall/extended-existential-symbolic-mangling-5.7 branch July 2, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants