[Constraint solver] Don't adjust types in calls to @preconcurrency functions #59849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functions When calling a `@preconcurrency` function, don't adjust the types of parameters. Instead, we'll suppress or alter diagnostics later on to deal with Sendable and global-actor mismatches. Fixes the crash from rdar://95995193, but diagnostics need more work.
Instead of the `warning` Boolean threaded through the solver's diagnostics, thread `DiagnosticBehavior` to be used as the behavior limit. Use this for concurrency checking (specifically dropped `@Sendable` and dropped global actors) so the solver gets more control over these diagnostics. This change restores the diagnostics to a usable state after the prior change, which introduced extra noise. The only change from existing beavior is that dropping a global actor from a function type is now always a warning in Swift < 6. This is partly intentional, because there are some places where dropping the global actor is well-formed.
DougGregor
changed the title
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
xedin
reviewed
Jul 1, 2022
The type checker is now permitting `@Sendable` closures whose captures can be by-reference, because we do not error. Remove an aspirational SIL verifier check that banned this.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling a
@preconcurrencyfunction, don't adjust the types of parameters, because SILGen considers such calls to be invalid and will assert. Instead, suppress or alter diagnostics later on to deal withSendableand global-actor mismatches.Fix rdar://95995193