-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ConstraintSystem] Improve initial constraints printing in the type inference algorithm debug output #59856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have left a couple of comments inline for you to address before we merge.
3d4ba19
to
2f42859
Compare
2f42859
to
ad3fcc8
Compare
ad3fcc8
to
31a02b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
@swift-ci please test |
@amritpan Looks like you forgot to adjust one of the tests with checks constraint system output. |
…led in that order for printing only.
31a02b7
to
e23576f
Compare
@swift-ci please test |
These changes reduce and reformat the initial constraints printed by the type inference algorithm's debug output. By reducing repetitive locators and better sorting the constraints, the possible constraints are easier to follow.
For example, the following disjunctions:
will now print as: