Skip to content

[cxx-interop] Update tests for foreign reference types #59877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

egorzhdan
Copy link
Contributor

@egorzhdan egorzhdan commented Jul 4, 2022

This fixes errors in tests:

/home/build-user/swift/test/Interop/Cxx/foreign-reference/Inputs/singleton.h:8:14: error: 'operator new' is missing exception specification 'noexcept'
inline void *operator new(size_t, void *p) { return p; }
             ^
/usr/lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/new:173:33: note: previous declaration is here
_GLIBCXX_NODISCARD inline void* operator new(std::size_t, void* __p) _GLIBCXX_USE_NOEXCEPT

It is a bit unfortunate that tests outside of Cxx/stdlib depend on the C++ stdlib, but I couldn't find a way around that.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jul 4, 2022
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-move-only-test branch from f954247 to e077124 Compare July 4, 2022 17:11
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan changed the title [cxx-interop] Update test for foreign reference types [cxx-interop] Update tests for foreign reference types Jul 4, 2022
This fixes errors in tests:
```
/home/build-user/swift/test/Interop/Cxx/foreign-reference/Inputs/singleton.h:8:14: error: 'operator new' is missing exception specification 'noexcept'
inline void *operator new(size_t, void *p) { return p; }
             ^
/usr/lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/new:173:33: note: previous declaration is here
_GLIBCXX_NODISCARD inline void* operator new(std::size_t, void* __p) _GLIBCXX_USE_NOEXCEPT
```
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-move-only-test branch from e077124 to 5aea919 Compare July 4, 2022 18:06
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan requested a review from zoecarver July 4, 2022 20:19
@egorzhdan egorzhdan merged commit c88a157 into main Jul 4, 2022
@egorzhdan egorzhdan deleted the egorzhdan/cxx-move-only-test branch July 4, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant