🍒[5.7][Distributed] Prevent overloading on async in distributed methods, for wire compat #59881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
This PR does not change the mangling strategy, but just prevents a compile time crash when declaring conflicting methods, as such, it can land a bit later if it has to. |
ktoso
changed the title
|
@swift-ci please test Linux |
|
Tho it seems this missed the train -- heh my bad. |
DougGregor
approved these changes
Aug 23, 2022
|
@swift-ci please test |
|
Thanks for review Doug! |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In order to be better for wire compatibility, we actually encode the
YaK(async throws) distributed thunk based names for the distributed accessible functions. This currently leads to crashes if one does overload on "just asyncness". After discussing if we should allow these overloads (#59831) or ban them (this PR) we came to the conclusion this is better for distributed calls. This PR bans async overloading on distributed methods.Risk: Low, prevents a crash by preventing bad declarations.
Review by: @DougGregor
Testing: PR testing
Original PR: #59880
Radar: rdar://96179707