Removing more calls to ValueDecl::getType() #5990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
removing-value-decl-get-type
branch
from
921f65a to
4876126
Compare
slavapestov
changed the title
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
removing-value-decl-get-type
branch
from
4876126 to
c9bc389
Compare
|
@swift-ci Please smoke test |
A pointless use of polymorphism -- the result values are not interchangeable in any practical sense: - For GenericTypeParamDecls, this returned getDeclaredInterfaceType(), which is an interface type. - For AssociatedTypeDecls, this returned the sugared AssociatedTypeType, which desugars to an archetype. - For TypeAliasDecls, this returned TypeAliasDecl::getAliasType(), which desugars to a type containing archetypes. - For NominalTypeDecls, this returned NominalTypeDecl::getDeclaredType(), which is the unbound generic type, a special case used for inferring generic arguments when they're not written in source.
The previous patches regressed a test where we used to diagnose (poorly) a circular associated type, like so: associatedtype e: e With the error "inheritance from non-protocol, non-class type 'e'". This error went away, because we end up not setting the interface type of the associated type early enough. Instead, we return an ErrorType from resolveTypeInContext() and diagnose nothing. With this patch, emit a diagnostic at the point where the ErrorType first appears. Also, remove the isRecursive() bit from AssociatedTypeDecl, and remove isBeingTypeChecked() which duplicates a bit with the same name in Decl.
slavapestov
force-pushed
the
removing-value-decl-get-type
branch
from
c9bc389 to
2ff9994
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
This broke two iOS tests. Reverting in #6019. |
|
Never mind, Slava pushed followups before my revert. We'll just fix it elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost ready to push it down to VarDecl.