[cxx-interop] Avoid importing too complex specializations #59906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the specialization limit from 10000 to 1000 to prevent Swift from failing to import libstdc++ due to `std::_Index_tuple` being defined recursively. This also adds a diagnostic to let the user know why a template instantiation wasn't imported. rdar://96324175
|
@swift-ci please smoke test |
zoecarver
reviewed
Jul 7, 2022
| @@ -626,6 +626,10 @@ class LLVM_LIBRARY_VISIBILITY ClangImporter::Implementation | |||
| llvm::DenseMap<clang::FunctionDecl *, ValueDecl *> | |||
| specializedFunctionTemplates; | |||
|
|
|||
| /// Stores qualified names of C++ template specializations that were too deep | |||
| /// to import into Swift. | |||
| llvm::StringSet<> tooDeepTemplateSpecializations; | |||
There was a problem hiding this comment.
Seeing the following:
Assertion failed: (isHandleInSync() && "invalid iterator access!"), function operator++, file DenseMap.h, line 1263.
Pretty sure this is the cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the specialization limit from 10000 to 1000 to prevent Swift from failing to import libstdc++ due to
std::_Index_tuplebeing defined recursively.This also adds a diagnostic to let the user know why a template instantiation wasn't imported.
rdar://96324175