Several fixes for performance diagnostics #59916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
force-pushed
the
perf-annotation-fixes
branch
from
0965598 to
3ed2472
Compare
|
@swift-ci test |
Just comment out the failing test (which needs rdar://90495704)
To avoid phase ordering problems of the involved optimizations, iterate until we reach a fixed point.
For performance annotations we need the generic specializer to trop non-generic metatype argumentrs (which we don't do in general). For this we need a separate mangling.
…unctions And replace them with explicit `metatype` instruction in the entry block. This allows such metatype instructions to be deleted if they are dead. rdar://94388453
Co-routines (called by `begin_apply`) may allocate and therefore it’s important to always inline them. Also, refactor the code a bit to fix the if-changed-then-return-true logic. rdar://94833845
This is important for performance diagnostics: it’s assumed that (non-generic) MemoryLayout constants do not need to create metadata at runtime. At Onone this is only guaranteed if the TargetConstantFolding pass runs. rdar://94836837
It was too conservative
…bles So far, initializers of global variables were ignored. The fix is to visit the called initializer of the builtin `once`. rdar://94780620
Check if no-escaping closures meet the performance constraints. Do this already when passing a closure to a function. rdar://94729207
eeckstein
force-pushed
the
perf-annotation-fixes
branch
from
3ed2472 to
abfa0a3
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several cases of missing errors and false alarms.
The fixes are mostly in the MandatoryGenericSpecializer pass, so that the generated code avoids locks and allocations.
A few fixes are directly in the PerformanceDiagnostics pass - in cases where the generated code is okay, but just the (not) emitted errors were wrong.
For details see the commit messages.
rdar://94388453
rdar://94729207
rdar://94780620
rdar://94833845
rdar://94836837