Adding actionable note to @main error #59919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler enters "script" mode if there is a file called `main.swift`, or if there is only one file. Parsing files as a script means that anything in the file is interpreted as top-level code, which is incompatible with a valid @main-annotated struct, so an error is emitted. Unfortunately, it is intentional in many cases, and the diagnostic didn't provide anything actionable to indicate that the explicit main function is intentional and that the file being passed in is not actually a top-level context. The new note indicates that passing `-parse-as-library` to the compiler invocation will fix it if the explicit main function is intentional.
|
@swift-ci please test |
nate-chandler
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Thanks! Nice improvement for the behavior of @UIApplicationMain/@NSApplicationMain/@main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler enters "script" mode if there is a file called
main.swift, or if there is only one file. Parsing files as a scriptmeans that anything in the file is interpreted as top-level code, which
is incompatible with a valid @main-annotated struct, so an error is
emitted.
Unfortunately, it is intentional in many cases, and the diagnostic
didn't provide anything actionable to indicate that the explicit main
function is intentional and that the file being passed in is not
actually a top-level context.
The new note indicates that passing
-parse-as-libraryto the compilerinvocation will fix it if the explicit main function is intentional.
rdar://89888060