[CMake] set OSX_ARCHITECTURES in add_swift_target_library_single
#59922
Conversation
This way we configure correctly `libBlocksRuntime`, which is not using `add_swift_target_library` (where the code for setting `OSX_ARCHITECTURES` currently lives, see swiftlang#38415 and swiftlang#38956) Addresses rdar://96469791
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
| # CMAKE_OSX_ARCHITECTURES to ensure that CMake would | ||
| # not add the -arch flag | ||
| # This is no longer the case when running on Apple Silicon, | ||
| # when CMake will enforce a default (see |
There was a problem hiding this comment.
Can you please reflow the text here?
There was a problem hiding this comment.
Had a stab at this in 29e2b18 -- is this looking better?
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
|
@swift-ci please build toolchain Linux |
|
Noticed in my first iteration I altered the semantics of the logic in a misguided effort to fit this into the existing conditions -- addressed this with d03731b |
|
@swift-ci please test |
|
@swift-ci please build toolchain |
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
|
@swift-ci please test Apple Silicon |
edymtt
deleted the
set_osx_architectures_in_add_swift_target_library_single
branch
…wiftlang#59922) This way we configure correctly `libBlocksRuntime`, which is not using `add_swift_target_library` (where the code for setting `OSX_ARCHITECTURES` currently lives, see swiftlang#38415 and swiftlang#38956) Addresses rdar://96469791
This way we configure correctly
libBlocksRuntime, which is not usingadd_swift_target_library(where the code for settingOSX_ARCHITECTUREScurrently lives, see #38415 and #38956)
Addresses rdar://96469791