Skip to content

Cleanup after recent refactoring for fix behaviors #59975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 9, 2022
Merged

Cleanup after recent refactoring for fix behaviors #59975

merged 5 commits into from
Jul 9, 2022

Conversation

DougGregor
Copy link
Member

Address commentary from #59958:

  • Rename a few ConstraintFix functions to make them more understandable
  • Sink logic for when to add a fix for concurrency-related issues down into attempt functions on the fixes

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

xedin
xedin approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I still think that "behavior" of the fix should be internal matter and propagated to the diagnostics via DiagnosticBehavior when diagnostics are constructed by ConstraintFix::diagnose method as I mentioned in the original PR.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test macOS

@DougGregor DougGregor merged commit 8ccaad3 into swiftlang:main Jul 9, 2022
@DougGregor DougGregor deleted the cleanup-fix-behavior branch July 9, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @xedin