[no-implicit-copy] A few small patches to simplify a larger patch. #60003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I already fixed SILMoveOnlyType -> SILMoveOnlyWrappedType in a previous commit and just forgot to hit the canonical type wrapper.
I keep on needing to use this in various internal APIs to the compiler that I don't want to have to make a public forward declared internal API.
…getASTType(). The reason why this makes sense is that this method is attempting to return the current SILType but with a different category. So using getASTType() here and by mistake removing move only would break semantics. Additionally, not making this change breaks the expectation that this API would be idempotent.
Basically the if/else statement of this section of code are unrelated by have the same condition (albeit inverted). Rather than keep them together and make them seem as related semantic checks, move the no implicit copy diagnostic into its own section. I am doing this as a separate commit partially to slim down the next series of commits.
…rapper and MarkMustCheck. Just slimming down a larger commit.
Just missed this.
…e in a generic way. Just so that people do not have to touch operand numbers and potentially make a mistake.
… take a MoveOnlyWrapped value. In the future, we may not have this requirement, but for now it is a really convenient way to track down places in SILGen where I have missed converting from copyable to moveonlywrapped types.
… copyable_to_moveonlywrapped. The reason why this is necessary is that the trivial input value doesn't have a cleanup associated with it, but the result of the instruction is owned. So otherwise we will not have a cleanup for the result, resulting in an OSSA error.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am preparing a last patch that implements the +0 support for no-implicit-copy as I discussed with @jckarter. To make that final PR easier to review, I am trying to slice off some parts of it into earlier self contained commits.