Adapt to llvm NamedRegionTimer changes #6003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm requires a Name/Description pair for NamedRegionTimers as of r287369. Because most of the previously used "names" for timers are actually longer descriptions containing multiple words and spaces. I added a Name parameter to the llvm side to produce machine parseable output with names that rather resemble a programming a language identifier rather than a sentence. This is the easiest possible fix that uses the existing string for name+description of the timer just to be compatible with the new API. It would be good if someone familiar with swift could add proper short names to the timers.
|
@swift-ci Please smoke test |
|
Yep and his fix is actually complete. I hope I calmed down the build for now by adding compatibility constructors to the llvm side. So I can look at the swift side (and probably abandon this) calmly tomorrow. |
|
@MatzeB Can this be closed? |
|
Yep, let's close it in favor of #5890 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm requires a Name/Description pair for NamedRegionTimers as of
r287369. Because most of the previously used "names" for timers are
actually longer descriptions containing multiple words and spaces. I
added a Name parameter to the llvm side to produce machine parseable
output with names that rather resemble a programming language
identifier rather than a sentence.
This is the easiest adaption fix for the API change that just uses the existing string for
name+description of the timer.
It would be good if someone familiar with swift could add proper short
names to the timers.