🍒[5.7][Distributed] Prevent remote distributed actor from running deinit body #60055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
airspeedswift
approved these changes
Jul 15, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Distributed Actor "remote" instances do not have storage initialized; yet we allowed
deinitfunction bodies to run on them, and only prevented theresignIDfrom being called -- this is wrong, we must not run user declared deinit bodies because they might be allowed to touch actor state, resulting in access to non-initialized memory and crashes.Risk: Low, affects only distributed actor deinits; has no effect on non-DA declarations; SIL changes are very minimal and actually much simpler than current branching code.
Review by: @DougGregor @kavon
Testing: PR testing
Original PR: #60050
Radar: rdar://96980182