Some improvements in WalkUtils and use the ValueUseDefWalker in the ReleaseDevirtualizer pass #60072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
force-pushed
the
walkers-in-release-devirtualizer
branch
2 times, most recently
from
cf73fb6 to
4088933
Compare
eeckstein
changed the title
|
@swift-ci test |
|
@swift-ci benchmark |
* "merge" the `Path` and `State` in WalkUtils into a single `WalkingPath`. This makes it simpler for clients to configure a path and additional state variables. EscapeInfo now defines `EscapePath` which includes the projection path and EscapeInfo's specific state variables. * Make the `WalkerCache` part of the WalkUtils, so that not all clients have to re-implement it. * Rename `walkDownResults` -> `walkDownAllResults` and `walkUpOperands` -> `walkUpAllOperands` and make these functions client configurable.
…al use-def walking implementation
eeckstein
force-pushed
the
walkers-in-release-devirtualizer
branch
from
4088933 to
872ded9
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for WalkUtils and EscapeInfo:
PathandStatein WalkUtils into a singleWalkingPath. This makes it simpler for clients to configure a path and additional state variables. EscapeInfo now definesEscapePathwhich includes the projection path and EscapeInfo's specific state variables.WalkerCachepart of the WalkUtils, so that not all clients have to re-implement it.walkDownResults->walkDownAllResultsandwalkUpOperands->walkUpAllOperandsand make these functions client configurable.And: use the
ValueUseDefWalkerinstead of the manual use-def walking implementation