Skip to content

[5.7] IRGen: Weakly link associated conformance descriptors when either the protocol or the associated requirement is weak #60075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

Cherry-pick of #60074.

Previously, only the associated requirement was considered when deciding whether to weakly link an associated conformance descriptor. This lead to unexpected strong linkage for some symbols, interfering with back deployment when integrating with some frameworks.

Resolves rdar://96974850

… protocol or the associated requirement is weak.

Previously, only the associated requirement was considered when deciding whether to weakly link an associated conformance descriptor. This lead to unexpected strong linkage for some symbols, interfering with back deployment when integrating with some frameworks.

Resolves rdar://96974850
@tshortli tshortli requested a review from a team as a code owner July 15, 2022 20:03
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli added the r5.7 label Jul 15, 2022
@tshortli tshortli merged commit 7f05516 into swiftlang:release/5.7 Jul 15, 2022
@tshortli tshortli deleted the weak-link-associated-conformance-descriptor-5.7 branch July 15, 2022 23:40
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants