[build-tooling-libs] Don’t configure extra stdlib content #60092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
akyrtzi
approved these changes
Jul 18, 2022
utils/build-tooling-libs
Outdated
| @@ -245,6 +245,8 @@ class Builder(object): | |||
| "-DSWIFT_BUILD_STATIC_STDLIB=FALSE", | |||
| "-DSWIFT_BUILD_DYNAMIC_SDK_OVERLAY=FALSE", | |||
| "-DSWIFT_BUILD_STATIC_SDK_OVERLAY=FALSE", | |||
| "-DSWIFT_BUILD_STDLIB_EXTRA_TOOLCHAIN_CONTENT=FALSE", | |||
| "-DSWIFT_BUILD_SYNTAXPARSERLIB=TRUE", | |||
There was a problem hiding this comment.
Maybe group
"-DSWIFT_BUILD_SYNTAXPARSERLIB=TRUE",
along with
cmake_args += [
"-DSWIFT_BUILD_ONLY_SYNTAXPARSERLIB=TRUE",
"-DSWIFT_BUILD_SYNTAXPARSERTEST=TRUE",
]
above, otherwise LGTM.
Configuring extra stdlib toolchain content while not building the stdlib fails due to missing compatibility libraries.
ahoppen
force-pushed
the
pr/fix-build-tooling-libs
branch
from
dfa4547 to
b835b96
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring extra stdlib toolchain content while not building the stdlib fails due to missing compatibility libraries.