[Sema] Provide copy constructor/assignment operator for TypeCheckRequ… #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est. One of the member variant of the union has a non-trivial copy constructor, therefore the copy cosntructor is implicitly deleted (in C++11). Provide the constructor and the copy assignment operator explictly in order to avoid build errors.
|
|
||
| TypeCheckRequest(const TypeCheckRequest &T) { *this = T; } | ||
|
|
||
| TypeCheckRequest& operator=(const TypeCheckRequest &T) { |
There was a problem hiding this comment.
Would this be equivalent to this? (I'm not entirely sure if that's legal, I haven't written C++ in a while)
TypeCheckRequest(const TypeCheckRequest &T) = default;
TypeCheckRequest& operator=(const TypeCheckRequest &T) = default;There was a problem hiding this comment.
No, it wouldn't. I tried that earlier and clang rejects it, I think correctly.
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2544.pdf and other papers talk about this.
|
@DougGregor has OK'ed this patch on the mailing list. I am running tests. |
|
@dcci Thanks for the patch, merging! |
gribozavr
added a commit
that referenced
this pull request
Dec 20, 2015
[Sema] Provide copy constructor/assignment operator for TypeCheckRequ…
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
XFAIL of ReactiveObjC applies to 5.5 branch as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…est.
One of the member variant of the union has a non-trivial copy
constructor, therefore the copy cosntructor is implicitly deleted
(in C++11). Provide the constructor and the copy assignment operator
explictly in order to avoid build errors.
Doug Gregor approved this on swift-dev.
https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151214/000329.html
Thanks!
Davide