[AST] Lazily compute the set of nested types of an ArchetypeType
#6011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superclass constraints are uncommon, so put them into trailing-object storage. Similarly, there's no reason to pay for the pointer + size of the array of protocols to which the archetype conforms when we can use trailing objects and existing padding bits. Note that the nested types are *not* tail-allocated because they will (eventually) be lazily allocated.
An ArchetypeType has all of the information it needs to lazily compute its set of nested types (hint: they're the associated types of all of the protocols to which it conforms). Do so only when asked about the nested types. Not that there are two levels of laziness happening here: first, we only create the (sorted) array of nested types when asked about the nested types the first time. Second, even when we do create it, we only record the names of these types---the actual archetypes (or concrete types) behind these names are lazily created when requested. Of course, all of this laziness is short-lived, because ArchetypeBuilder::getGenericEnvironment() forces all of the archetypes to be constructed.
|
@swift-ci please smoke test and merge |
|
Fixed some crashers? Oh darn |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazily expand out the list of nested types of an
ArchetypeType. The archetype builder need not be involved.While I'm here, optimize the storage of
ArchetypeTypewith more trailing objects.