[CSSolver] Don't skip generic overloads when non-generic one has SK_U… #60122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serConversion In cases where matched concrete overload used a bridging, CF*, or `AnyHashable` conversion, let's attempt generic overload choices as well because one of them could produce a better solution e.g. `RawRepresentable` for `==` where underlying type conforms to `Equatable` has a better generic match than `(AnyHashable, AnyHashable) -> Bool`. Resolves: rdar://95992916
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
hborla
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…serConversion
In cases where matched concrete overload used a bridging, CF*, or
AnyHashableconversion, let's attempt generic overload choicesas well because one of them could produce a better solution e.g.
RawRepresentablefor==where underlying type conforms toEquatablehas a better generic match than
(AnyHashable, AnyHashable) -> Bool.Resolves: rdar://95992916