[Sema] Mark variables as hole while diagnosing a optional payload #60126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
xedin
reviewed
Jul 19, 2022
xedin
reviewed
Jul 19, 2022
LucianoPAlmeida
force-pushed
the
hole-invalid-ref
branch
2 times, most recently
from
0de4877 to
6d0c718
Compare
LucianoPAlmeida
force-pushed
the
hole-invalid-ref
branch
from
6d0c718 to
5ea17d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case compiler was not being able to produce a diagnostic when attempting overloads for
enumeratedwith a hole variablevaluescoming from an invalid decl ref as base.So to fix this, let's mark type variables as potential hole when failing on optional payload to handle such cases.
Resolves #60029.