[5.7][CSSimplify] Don't fix invalid r-value use for misplaced &
#60130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
When `&` is misplaced it creates r-value -> l-value mismatch in the code which is just a consequence and shouldn't be diagnosed. Resolves: rdar://96631324 (cherry picked from commit ff61120)
|
@swift-ci please clean test |
|
@swift-ci please nominate |
hborla
approved these changes
Jul 19, 2022
|
@swift-ci please test macOS platform |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #60024
When
&is misplaced it creates r-value -> l-value mismatchin the code which is just a consequence and shouldn't be diagnosed.
Scope: Invalid assignments with incorrectly used
&on the right-hand side.Main Branch PR: [CSSimplify] Don't fix invalid r-value use for misplaced
Resolves: rdar://96631324
Risk: Very low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: rdar://96631324
(cherry picked from commit ff61120)