[5.7][AST] SE-0347: Don't check default expression status in type request #60132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please clean test macOS platform |
|
@swift-ci please nominate |
hborla
approved these changes
Jul 19, 2022
|
@swift-ci please test macOS platform |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #60109
Fixes a bug in "inference from defaults" feature implementation.
Information about whether or not default expression is type-checked
is not going to be available for deserialized declaration and it's
not necessary for type requests anyway.
Scope: Declarations in frameworks with default argument expressions that could be used to infer types at a call site.
Main Branch PR: [AST] SE-0347: Don't check default expression status in type request #60109
Resolves: rdar://95990526
Risk: Very low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: rdar://95990526