[cxx-interop] Remove impl for constexpr members #60154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
compnerd
approved these changes
Jul 20, 2022
zoecarver
reviewed
Jul 20, 2022
lib/ClangImporter/ImportDecl.cpp
Outdated
| } | ||
| if (!value) | ||
| // For now we don't import constexpr | ||
| if (decl->isConstexpr()) |
There was a problem hiding this comment.
This should only be static constexpr vars, right? Other vars should work fine (it's just because there's no symbol for static constexpr vars).
|
@swift-ci please smoke test |
|
LGTM thanks. |
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jul 28, 2022
* Remove impl for constexpr members * Readd some tets * Only remove import of static constexpr
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only support constexpr members for int and float types. Unfortunately templated constexpr members are more difficult to handle and are causing some issues when importing c++ stdlib on windows msvc.
For now we will drop support for constexpr members in general until we figure out a better approach for importing them