NFC: Test printing swiftinterfaces containing declarations originally written using typealiases from another module #60179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e written using typealiases from another module. This test establishes a baseline for the behavior of swiftinterface emission when public declarations of all kinds reference typealiases from another module. It seems that for many types of declarations, the printer is looking through the typealias definition and printing the original type instead of a fully qualified reference to the typealias. This behavior can cause swiftinterfaces to be unparsable since the original type may not be declared in the module declaring the typealias. Every CHECK line in this test that includes a reference to fully qualified type from the `Original` module represents an instance of this bug. Once this behavior is corrected, it should be possible to succesfully parse `UsesAliases.swiftinterface` and the `RUN:` line for doing so should be uncommented.
|
@swift-ci please smoke test |
|
@slavapestov @CodaFi Are you aware of this issue by chance? Or would you know what could make the compiler print the underlying type of typealiases when used in the context of generics, I think this issue has been present for a while now, it's affecting a decent number of swiftinterfaces. |
|
CC @hborla |
I'm aware of this behavior with |
…d errors about using `some` types when they might be unavailable.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test establishes a baseline for the behavior of swiftinterface emission when public declarations of all kinds reference typealiases from another module. It seems that for many types of declarations, the printer is looking through the typealias definition and printing the original type instead of a fully qualified reference to the typealias. This behavior can cause swiftinterfaces to be unparsable since the original type may not be declared in the module declaring the typealias.
Every CHECK line in this test that includes a reference to fully qualified type from the
Originalmodule represents an instance of this bug.Once this behavior is corrected, it should be possible to succesfully parse
UsesAliases.swiftinterfaceand theRUN:line for doing so should be uncommented.