Push ValueDecl::{has,get,set}Type() down to VarDecl #6018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After recent changes, this asserts on all decls that are not VarDecls, so we can just enforce that statically now. Interestingly, this turns up some dead code which would have asserted immediately if called. Also, replace AnyFunctionRef::getType() with AnyFunctionRef::getInterfaceType(), since the old AnyFunctionRef::getType() would just assert when called on a Decl.
slavapestov
force-pushed
the
finish-removing-value-decl-get-type
branch
from
5e3481e to
26c8042
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueDecl::getInterfaceType()was added more than three years ago in this commit by @DougGregor: 12e228cAnd now, as planned, it can finally replace
ValueDecl::getType().Next steps here for the curious:
VarDecl::getType()if called on a var that's not in local context