🍒[5.7][IRGen/Distributed] Adjust protocol requirement and witness table to handle distributed thunks #60189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lRef` While building witness table record, let's use `hasAsync()` check on `SILDeclRef` of the requirement instead of reaching for the underlying declaration because the reference should be the source of truth about `async` and other attributes. In case of distributed thunk witness, which is always `async throws`, the underlying declaration could be sync because it's the protocol requirement declaration.
… async Fixes a bug where descriptor for protocol requirement associated with distributed thunk wasn't marked as `async` that results in ptrauth failures because discriminator would be misaligned between requirement and witness. Resolves: rdar://96520492
|
@swift-ci please test |
|
@swift-ci please test apple silicon |
|
@swift-ci please nominate |
|
5.7 Linux CI is broken: rdar://97408321 |
|
swiftlang/swift-package-manager#5684 |
|
swiftlang/swift-package-manager#5684 |
|
swiftlang/swift-package-manager#5684 |
|
Reverts got merged (and thus failures like @swift-ci please test apple silicon |
|
@swift-ci please test apple silicon |
|
@swift-ci please test |
|
We're green, yay! Just need approval now 🙏 |
airspeedswift
approved these changes
Jul 22, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Pointer authentication would fail on arm64e for distributed method witnesses where the requirement. This PR makes the necessary changes for the verification to look at the right discriminators.
This is necessary because SILDeclRef of the distributed thunk witness is anchored
on the requirement declaration which might not be async, but the witness itself is
always async throws.
Fixes a bug where descriptor for protocol requirement associated with
distributed thunk wasn't marked as async that results in ptrauth failures
because discriminator would be misaligned between requirement and witness.
Risk: Low, only fixes pointer auth for distributed protocol requirements and actors
Review by: @DougGregor @tkremenek
Testing: PR Testing, validated on arm64e
Original PR: #60184
Radar: rdar://97228310 rdar://96520492