[SourceKit] Add an operator syntax kind #60210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
previously approved these changes
Jul 24, 2022
lib/IDE/SyntaxModel.cpp
Outdated
| @@ -231,9 +231,18 @@ SyntaxModelContext::SyntaxModelContext(SourceFile &SrcFile) | |||
| break; | |||
|
|
|||
| case tok::oper_prefix: | |||
| if (Tok.getText() == "-") | |||
| if (Tok.getText() == "-") { | |||
There was a problem hiding this comment.
Suggested change
| if (Tok.getText() == "-") { | |
| if (Tok.getText() == "-" && I != E && | |
| (Tokens[I+1].getKind() == tok::integer_literal || | |
| Tokens[I+1].getKind() == tok::floating_literal)) { |
So that prefix - for non-numeric literals are classified as Operator
ahoppen
force-pushed
the
pr/operator-syntax-kind
branch
from
cdf47e1 to
8c70a8a
Compare
This will allow us to do semantic highlighting for operators in SourceKit-LSP.
ahoppen
force-pushed
the
pr/operator-syntax-kind
branch
from
8c70a8a to
a7dcd46
Compare
|
@swift-ci Please smoke test |
rintaro
approved these changes
Aug 2, 2022
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Aug 12, 2022
Adopts swiftlang/swift#60210 Resolves swiftlang#595 rdar://97961816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to do semantic highlighting for operators in SourceKit-LSP.
swiftlang/sourcekit-lsp#595