Skip to content

IRGen: Add a list of class_ro_t referenced from generic class metadata patterns to a section __swift_rodatas #60231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aschwaighofer
Copy link
Contributor

@aschwaighofer aschwaighofer commented Jul 25, 2022

Put pointers to class_ro_t referenced from generic class patterns in a section __swift_rodatas such that they are discoverable by the linker.
The linker can then make the method lists contained in the class_ro_t relative like it can for objective c class metadata from non-generic swift classes.

rdar://66634459

@aschwaighofer aschwaighofer force-pushed the generic_objc_method_list_section branch from edddf31 to 6429805 Compare July 26, 2022 15:49
@aschwaighofer aschwaighofer changed the title IRGen: Add method lists of generic class patterns to their own section IRGen: Add a list of class_ro_t referenced from generic class metadata patterns to a section __swift_rodatas Jul 26, 2022
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer aschwaighofer marked this pull request as ready for review July 27, 2022 23:21
@aschwaighofer aschwaighofer force-pushed the generic_objc_method_list_section branch from 6429805 to 79cc847 Compare July 27, 2022 23:21
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

…a patterns to a section __swift_rodatas

Put pointers to class_ro_t referenced from generic class patterns in a section __swift_rodatas such that they are discoverable by the linker.
The linker can then make the method lists contained in the class_ro_t relative like it can for objective c class metadata from non-generic swift classes.

rdar://66634459
@aschwaighofer aschwaighofer force-pushed the generic_objc_method_list_section branch from 79cc847 to 6ce452b Compare July 29, 2022 18:49
@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer aschwaighofer merged commit 78f5e0b into swiftlang:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant