Skip to content

[5.7][Runtime] Fix rare crash when fixing up dynamic subclasses. #60245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[5.7][Runtime] Fix rare crash when fixing up dynamic subclasses. #60245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stdlib/public/runtime/Metadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,8 @@ static void swift_objc_classCopyFixupHandler(Class oldClass, Class newClass) {
reinterpret_cast<void *const *>(&src[i]),
descriptors[i].Flags.getExtraDiscriminator(),
!descriptors[i].Flags.isAsync(),
/*allowNull*/ false); // Don't allow NULL for Obj-C classes
/*allowNull*/ true); // NULL allowed for VFE (methods in the vtable
// might be proven unused and null'ed)
}
}

Expand Down
Loading