Skip to content

Fix warnings building swift/ABI with MSVC #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Fix warnings building swift/ABI with MSVC #6031

merged 1 commit into from
Dec 12, 2016

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Dec 2, 2016

  • Your bog-standard unhandled control path warnings. Can't use llvm_unreachable as this is used in the stdlib where we can't link LLVM

@compnerd
Copy link
Member

compnerd commented Dec 3, 2016

I think that covering the switch with the one missing value with an llvm_unreachable is nicer.

@hughbe
Copy link
Contributor Author

hughbe commented Dec 3, 2016

@compnerd we can't use llvm_unreachable - this is part of the stdlib and I get linker errors for unresolved external llvn_unreachable_internal when compiling the stdlib if we us unreachable.

@hughbe
Copy link
Contributor Author

hughbe commented Dec 8, 2016

Will update to use swift_unreachable when #6025 is merged

@compnerd
Copy link
Member

@hughbe #6205 is merged

@hughbe
Copy link
Contributor Author

hughbe commented Dec 11, 2016

Thanks @compnerd. I've updated this :)

@compnerd
Copy link
Member

@swift-ci please test and merge

@hughbe
Copy link
Contributor Author

hughbe commented Dec 12, 2016

@compnerd tests passed. can you merge manually, thanks

@compnerd
Copy link
Member

@swift-ci please smoke test OSX platform

@compnerd
Copy link
Member

Just being a bit more paranoid :)

@compnerd
Copy link
Member

@swift-ci please smoke test OS X platform

@hughbe
Copy link
Contributor Author

hughbe commented Dec 12, 2016

@jrose-apple can we merge this in, then I'll rename swift_unreachable to swift_runtime_unreachable. Thanks!

@jrose-apple jrose-apple merged commit d93d24b into swiftlang:master Dec 12, 2016
@hughbe hughbe deleted the abi-msvc branch December 12, 2016 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants