Skip to content

[cxx-interop] Fix issue where multiple records in a module containing the same meth… #60338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

Huddie
Copy link
Contributor

@Huddie Huddie commented Aug 1, 2022

If 2 records in the same module had the same method name but methods differed in constness the logic that mutates the mutable one into FooMutating would still get called.

…od names but differing consteness would cause an name mutation
@Huddie Huddie added the c++ interop Feature: Interoperability with C++ label Aug 1, 2022
@Huddie Huddie requested review from zoecarver and egorzhdan August 1, 2022 18:01
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for the fix!

@zoecarver
Copy link
Contributor

@swift-ci please test.

@Huddie
Copy link
Contributor Author

Huddie commented Aug 1, 2022

@swift-ci please test

@Huddie Huddie merged commit 379fc1f into swiftlang:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants