Adding the Backdeploy 5.6 compatibility library #60368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch gets everything to the point of building the library, but it doesn't run yet since I have missing symbols. Unlike previous compatibility libraries and the concurrency compatibility library, I'm organizing the headers a bit more. This is because we're merging the two libraries into one. They share some common header names, and while I could rename them for namespacing purposes, it's easier to just use a directory structure for this. The `include/Runtime` and corresponding `Runtime/` directories are for backdeployed changes to the stdlib itself. The `include/Concurrency` and corresponding `Concurrency/` directories are for backdeployed changes to the concurrency runtimes.
This patch removes the implementation implementations and just calls the original symbol without the fixes. This allows the library to build and for binaries to link against it without breaking anything with missing symbols.
|
@swift-ci please test |
|
Also, if someone knows how to actually test these backdeploy libraries with anything beyond "it compiles, ship it", I'm all ears. |
This patch updates the concurrency backdeployment test to handle the inclusion of the Swift 5.6 compatibility library. macOS12 will have the 5.6 library applied to it, so the _swift_FORCE_LOAD_$_swiftCompatibility56 symbol is defined weakly.
|
@swift-ci please test |
|
Updated the |
DougGregor
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts adding the stubs for the Swift 5.6 back deployment compatibility library.
At this time it adds the ability to set the
-runtime-compatibility-versionto5.6in order to link the compatibility library, and declares two symbols for theswift_task_future_waitandswift_task_future_wait_throwingfunction replacements.These functions currently just forward the call to the original implementation.
I have checked that this library is actually used by running
then inspecting and executing the resulting binary.