[Diagnostics] Update existential type error message for clarity #60390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazevedofs
force-pushed
the
existential-error-message
branch
from
7ca1d9f to
637e2d4
Compare
hborla
approved these changes
Sep 2, 2022
|
@swift-ci please smoke test |
|
@mazevedofs CI failure is because tests have to be updated in |
@LucianoPAlmeida That's right! Is there a way to run this test locally so I can properly test it? |
Yes, we can use lit to run them locally against our ninja build. The exact commands are here in Running Tests section =] |
Rework solution to be squashed
mazevedofs
force-pushed
the
existential-error-message
branch
from
637e2d4 to
68687a6
Compare
|
@swift-ci Please test |
|
Given that @hborla approved already, let's land it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
redundant_any_in_existentialerror message by making it more explicit that the issue is the redundantanykeyword.Note: This is my first pull request as part of the Swift Mentorship.
@hborla I guess it's ready for review :)