Tests: Fix tests that were using non-existent FileCheck directive CHECK-DAG-LABEL:
#60397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directive) in dynamically_replaceable.sil.
…ck directive) in weak_import_native.swift. Fix CHECK lines that were out of date and add some missing CHECK lines.
…w test case. Once the `CHECK-DAG` directives in `weak_import_native` were being recognized correctly, the `CHECK:` lines later in the test were interfering with `CHECK-DAG` matches because some of them straddled the existing `CHECK:` lines.
tshortli
commented
Aug 4, 2022
|
|
||
| import weak_import_native_hoist_helper | ||
|
|
||
| // We should not hoist the metadata accessor accross the version check. |
There was a problem hiding this comment.
This test case is purely a copy paste of the original lines from weak_import_native.swift with the mangled names updated.
…e it isn't emitted on Linux.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across a couple tests that were using
CHECK-DAG-LABEL:which isn't currently a real FileCheck directive. As a result, a large number of the assertions in these tests were not actually being checked. I replacedCHECK-DAG-LABELwithCHECK-DAGand then fixed the fallout.weak_import_native.swiftrequired the most significant updates: