Sema: New syntax for @opened archetypes in textual SIL #60429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
sil-opened-archetype-syntax
branch
from
863ad15 to
3bbf815
Compare
slavapestov
force-pushed
the
sil-opened-archetype-syntax
branch
3 times, most recently
from
80dc346 to
cf45a62
Compare
|
@swift-ci Please test |
The old syntax was
@opened("UUID") constraintType
Where constraintType was the right hand side of a conformance requirement.
This would always create an archetype where the interface type was `Self`,
so it couldn't cope with member types of opened existential types.
Member types of opened existential types is now a thing with SE-0309, so
this lack of support prevented writing SIL test cases using this feature.
The new syntax is
@opened("UUID", constraintType) interfaceType
The interfaceType is a type parameter rooted in an implicit `Self`
generic parameter, which is understood to be the underlying type of the
existential.
Fixes rdar://problem/93771238.
slavapestov
force-pushed
the
sil-opened-archetype-syntax
branch
from
cf45a62 to
d222ac5
Compare
|
@swift-ci Please test |
atrick
reviewed
Aug 8, 2022
| visit(T->getGenericEnvironment()->getOpenedExistentialType()); | ||
| Printer << ") "; | ||
|
|
||
| llvm::DenseMap<CanType, Identifier> newAlternativeTypeNames; |
There was a problem hiding this comment.
Seems like this DenseMap could be a SmallDenseMap since it doesn't escape, normally has one entry, and we regularly print giant .sil files (like up to 100MB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old syntax was
Where constraintType was the right hand side of a conformance requirement.
This would always create an archetype where the interface type was
Self,so it couldn't cope with member types of opened existential types.
Member types of opened existential types is now a thing with SE-0309, so
this lack of support prevented writing SIL test cases using this feature.
The new syntax is
The interfaceType is a type parameter rooted in an implicit
Selfgeneric parameter, which is understood to be the underlying type of the
existential.
Fixes rdar://problem/93771238.