[5.7] Canonicalize the conforming type of BuiltinConformances. #60439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out they aren't always canonical by construction (and they don't really need to be), so we should canonicalize the type and requirements when we canonical a conformance ref. Fixes rdar://94877954.
|
@swift-ci Please test |
DougGregor
approved these changes
Aug 8, 2022
hborla
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: An inconsistency in the internal representation of tuple
Sendableconformances could cause the compiler to crash when handling opaque return types from SwiftUI'sWindowGroup.backgroundTaskmodifier.Scope: Fixes a compiler crash on valid SwiftUI code.
Issue: rdar://94877954.
Risk: Low. Fixes a logic error by canonicalizing protocol conformance representations that were not canonical.
Testing: Project from bug report, Swift CI
Reviewed by: @slavapestov