[Interop][SwiftToCxx] add support for resilient enum #60451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rebase :) |
WANGJIEKE
force-pushed
the
cxx-interop-resilient-enum
branch
from
fcf25a4 to
ff28b56
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
2 similar comments
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility |
hyp
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
IRABIDetailsProvider::getEnumTagMappingso that it will also return the global variable name for the enum tagoperator casesin the printed header: supporting resilient enumbool isXyz()in the printed header: these functions will compare with the tag constants (non-resilient) or tag global variables (resilient) directlybool inResilientUnknownCase()in the printed header for resilient enum, allowing checking if the enum is in an unknown case_implnamespace of printed header@hyp Could you please review this pull request? Thanks.