RequirementMachine: Fix crash-on-invalid with recursive same-type requirements #60507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype and superclass requirements A requirement of the form T == G<T> is never valid, and T == G<T.A> will leave behind a term T.[P:A] once the conformance T : P is dropped in contraction. So just ignore recursive requirements here, allowing them to be properly diagnosed later.
Note the test cases in abstract_type_witnesses used to pass but are now rejected. This is fine, because doing anything more complicated used to crash, and the GSB would crash or misbehave with these examples.
slavapestov
force-pushed
the
rqm-occurs-check
branch
from
211efbc to
9339443
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.