MissingDeclSyntax Can Have Attributes and Modifiers #60513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strange as it sounds, we parse @foo public in item position as a decl that has a hanging attribute and access control modifier. We need to be able to stick... something in the tree here so we don't just drop these tokens on the floor.
|
@swift-ci smoke test |
ahoppen
reviewed
Aug 11, 2022
There was a problem hiding this comment.
I wonder whether a better design would be to have a
Node('AttributedDecl', kind='Decl', children=[
Child('Attributes', kind='AttributeList',
collection_element_name='Attribute', is_optional=True),
Child('Modifiers', kind='ModifierList',
collection_element_name='Modifier', is_optional=True),
Child('Decl', kind='Decl'),
]),remove Attributes and Modifiers from the existing Decl types and then just use an AttributedDecl with a MissingDecl as the Decl child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strange as it sounds, we parse
@foo public
in item position as a decl that has a hanging attribute and access
control modifier. We need to be able to stick... something in the
tree here so we don't just drop these tokens on the floor.