Add missing function conversion for member access to preconcurrency vardecl. #60521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
kavon
force-pushed
the
preconcurrency-var-access
branch
from
8d73be0 to
d60835e
Compare
|
@swift-ci please test |
…rences We intended to introduce AST conversions that strip concurrency attributes off of types associated with `@preconcurrency` decls. But for VarDecl references, we stripped it too early, leading to things like a MemberVarDecl that doesn't have `@Sendable` in its result type, but the VarDecl it refers to does have it. That caused crashes in SIL where types didn't match up. This patch fixes things by delaying the stripping until the right point. resolves rdar://98018067
We needed a way to describe an ABI-safe cast of an address representing an LValue to implement `@preconcurrency` and its injection of casts during accesses of members. This new AST node, `ABISafeConversionExpr` models what is essentially an `unchecked_addr_cast` in SIL when accessing the LVAlue. As of now I simply implemented it and the verification of the node for the concurrency needs to ensure that it's not misused by accident. If it finds use outside of that, feel free to update the verifier.
kavon
force-pushed
the
preconcurrency-var-access
branch
from
6e0a8be to
a4d661d
Compare
kavon
changed the title
|
@swift-ci please test and merge |
This was referenced Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In something like:
We'd strip the
@Sendableoff the@preconcurrencyvarNSTouchGrass.cancellationHandlerin the AST without using a function conversion. This resulted in an AST like the following, which confuses SILGen and causes a crash:So this patch makes sure that the member reference does result in something that is
@Sendable, but the reference is followed by an appropriate conversion.Resolves rdar://98018067